Show the Welcome modal on the dashboard. #12036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techanvil
commented
Jan 6, 2026
| lastWidgetAnchor === ANCHOR_ID_MONETIZATION, | ||
| } ) } | ||
| /> | ||
| <OfflineNotification /> |
Collaborator
Author
There was a problem hiding this comment.
It's out of scope, but I've removed this duplicate <OfflineNotification />, having spotted that it's rendered twice when it should only be rendered once.
|
Storybook is ready:
|
|
Size Change: +3.4 kB (+0.15%) Total Size: 2.23 MB
ℹ️ View Unchanged
|
|
Build files for 60516c0 have been deleted. |
techanvil
commented
Jan 6, 2026
|
|
||
| const showTooltip = useShowTooltip( tooltipSettings ); | ||
|
|
||
| const closeAndDismissModal = useCallback( async () => { |
Collaborator
Author
There was a problem hiding this comment.
I diverged slightly from the IB to ensure the modal is closed & items dismissed when clicking the Start tour button, while not showing the tooltip (the click handler can be extended when we implement the tour).
nfmohit
requested changes
Jan 10, 2026
Collaborator
nfmohit
left a comment
nfmohit
left a comment
There was a problem hiding this comment.
Thank you for the brilliant work on this, @techanvil.
I've left a very few minor comments for your review. Please let me know what you think. Thanks!
techanvil
force-pushed
the
enhancement/11809-show-welcome-modal
branch
from
15bdc06 to
60516c0
Compare
nfmohit
approved these changes
Jan 12, 2026
Collaborator
nfmohit
left a comment
nfmohit
left a comment
There was a problem hiding this comment.
LGTM ✅
Note: I've verified that the failing VRT scenario is unrelated to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist